gmshortcutkeys missing in 1.7.4

[petefinnigan]

Hi Guys,

I have upgraded all of blogs now to 1.7.4 and yesterday whilst posting a new entry i found that the gmshortcutkeys is missing again. I have not had a look yet to see whats needed to put them back but will do so later. I just wanted to flag it here for now so its recorded.

cheers

Pete

[coldstone]

Hi Pete, we had talked about not using the shortcut keys once there were formatting buttons available. I know they are kinda ugly for now, but they should be cross-browser compatible.

[petefinnigan]

Hi Coldstone,

thanks for your reply. Yes; sorry i do remember our discussion on that. However I don't see any buttons in IE or Firefox to allow me to highlight text and add a LINK, BOLD or ITALIC as i could with gmShortcutkeys. Maybe I miss something?

thanks

pete

[coldstone]

Its currently tied to 'Allow easy formatting' option. Do you have that enabled?

[petefinnigan]

Hi Coldstone,

Thanks for your reply. I didn't reaslise that you added this under the easy formatting, as that feature used to be just for bold, italics and underline I think and not links and the shortcutkeys was in addition to this feature. I have enabled it on my test blog to try it and I will enable on all my blogs. You are right the buttons are not the best.., It should be difficult to create some nice graphics buttons to use instead though.

Thanks,

solved.

Cheers

Pete

[coldstone]

Yes, I am hoping there might be a rogue graphic artist among the Greymatter users. Otherwise, I just haven't looked for free icon sets, but I am sure they are out there.

[petefinnigan]

Hi Coldstone,

I found another problem in this area. in lookingat another issue this morning for another thread about having multiple GM blogs i went to my web dev blog to find the links to tow posts i made on this subject and found that the pages were corrupted. The links were bloken by span classes and % characters. I guessed that the corruption was because I enabled easy formatting and rebuilt in line with this thread and as i didnt do it to my other blogs they were OK. So i removed the easy format setting and rebuilt again, all the links were then fixed.

cheers

Pete

[coldstone]

Hmm, I think I fixed this last night. I should have tested this feature more.

Basically, if you look through the core code Gm_Core.pm, you will find 5 places where there is a regular expression matching the '//' chars, but its escaped so search for '\/\/'. You will want to remove these five lines or modify them. They are at: 1647, 1653, 2317, 2324, 3823.

If you still want the italic shorthand to work, then change:

=~ s/\/\/(.*?)\/\//<span style="font-style: italic;">$1<\/span>/isg;

to:

=~ s/(\s+)\/\/(.*?)\/\//$1<span style="font-style: italic;">$2<\/span>/isg;


This will be fixed in 1.8.1 and I am thinking this might be a big enough annoyance to release a 1.7.4.1 (it would really just have a new Gm_Core.pm). Sound good?

[petefinnigan]

Hi Coldstone,

thanks for the prompt fix. Yes i agree, this I think warrants a .1 release especially as its corrupting posts.

cheers

Pete

[coldstone]

I'll try to get this posted tonight or tomorrow. Also, I realized that the linking buttton should always appear since this isn't really related to the 'easy formatting'.

[petefinnigan]

Hi Coldstone,

Thanks for the update, yes I agree the link button is not really easy formatting.

cheers

Pete