|
Post by astanley on Jul 5, 2007 16:02:56 GMT -5
Hi. Long time (6+ years?) Greymatter user. I've decided that the time is right to upgrade from 1.3. So I copied everything from my host to a test account to do some testing. I've gotten 1.7.3 installed and configured. It seems to be a bit more sensitive to some issues that have appeared over the years. I can't do a detect and repair, which seems weird. It just stops working with a 500 error. This also happens when I try to rebuild manual entries. I focused on a popular page I have. It has close to 1000 enties. When I try to edit the page I got 438 entries to appear, but at the top it said: Software error: Invalid "digit" argument given to _padDigits: In libs/Gm_Utils.pm at 255 (Gm_Utils), called by Gm_Utils::_padDigits() In gm-library.cgi at 6506 (main), called by Gm_Utils::toTwoDigit() In gm.cgi at 153 (main), called by main::gm_editthisentry() at libs/Gm_Utils.pm line 308.
I feel confident that I could upgrade to 1.7.3 at my normal ISP and then back it out if the upgrade didn't work, but before I did anything I wanted to check with the forum. Any thoughts? Thanks in advance! Adam -- Adam Stanley astanley@echoes.com www.echoes.com/
|
|
|
Post by petefinnigan on Jul 5, 2007 16:22:19 GMT -5
Hi,
before we dig into the code, i am confused by what you mean by edit an entry, are you saying you are going the edit entry screen and it fails there or are you taking about a rebuild?
the 500 error should be fixed first as that clearly indicates an issue.
If you have been in GM for 6 years perhaps your Perl version is not up to scratch? - what version are you on. Second the code has chnaged a lot, please check you have all the perms correct on the .cgi files and also the new libs directory.
Also I am interested as to what the "sensitive" issues are?
cheers
Pete
|
|
|
Post by coldstone on Jul 6, 2007 16:20:28 GMT -5
When you say entries, you mean comments?
Greymatter has become pickier about the data it works on, due to security and other issues. As Greymatter is updated and refactored, it will catch the bad data and handle it better, rather than giving up (as it is currently doing).
I would guess that comment #439 has some bad data in it. You might be able to edit entry (in plain text mode) and look for any goofy characters. It could be that the date for that comment is missing or bad. The gm_dev_guide details the format of the comments:
The comments are stored in the fifth line and beyond, with the following information separated by the '|' character:
1. name = commenter's name alphanumeric 2. ip = in the form of xxx.xxx.xxx.xxx 3. email = in the form of user@email.com. If not provided, left blank. 4. homepage = commenter's webpage in the form of http://www.site.com. If not provided, left blank. 5. weekday = of comment numeric (0-6, 0=Sunday, 1=Monday, etc.) 6. month = of comment numeric (1-12, no leading zeroes) 7. day = of comment numeric (1-31, no leading zeroes) 8. year = of comment numeric (format: yyyy) 9. hour = of comment numeric (1-12, no leading zeroes) 10. minute = of comment numeric (1-12, no leading zeroes) 11. second = of comment numeric (1-12, no leading zeroes) 12. ampm = either AM or PM 13. comment = text presented all on one line, with the same text replacement conventions as in the main entry text. (See Line 3.)
So check line #444 (comments start on line 5) and post it if you don't see anything off hand (or even a few lines from that area of the file).
|
|
|
Post by astanley on Jul 8, 2007 6:56:20 GMT -5
Thanks to both of you for your tips. I've decided that I need to move my testing to my ISP and that's when I discovered that they only had perl5.005 installed. I found a copy of perl5.8.8 and I'm back stuck trying to figure out why I get 500 errors. So like Pete said, I need to figure that out first. To answer some quick questions.... Sorry that I confused entries and comments... Yes, I have an entry with about 1000 comments. I'll check to make sure that there are no bad characters in the comments. I do have this mysterious entry that was missing from gm-entrylist.cgi but I just recently hacked it back in. GM1.3 seem to perform fine with the missing entry. I think that I had another entry where the line in gm-entrylist.cgi was corrupt. Thanks for posting the layout. So far as my comment about sensitivity... I may have been overreacting. It's slow (especially with the page with 1000 comments which gets spammed constantly). Weird missing entries. Old perl (which is my issue, not yours). And upgrading is tricky (again, my issue, which you have been gracious enough to help with!). Thanks again for the tips... I'll keep working on things! Adam -- Adam Stanley astanley@echoes.com www.echoes.com/
|
|
|
Post by astanley on Jul 9, 2007 5:36:02 GMT -5
Just a quick update... Perl5.8.8 is not configured correctly at my ISP so they are working on it. Stay tuned!
|
|
|
Post by coldstone on Jul 9, 2007 16:48:56 GMT -5
Let us know. We always appreciate feedback and are looking for ways to make it easier for people to move to the newest version of Greymatter.
|
|
|
Post by astanley on Jul 16, 2007 21:26:25 GMT -5
OK... My ISP upgraded perl to 5.8.8 and everythings seems great! I did discover that I had some corruption in bunch of comments on my most popular page. I deleted those lines by hand and I was able to do a repair and everything repaired ok.
Now there's only two weird things that I've noticed and I'm not sure if it's my issue or not. I copied /greymatter to /greymatter173 and edited (by hand) the gm-config.cgi to point to the new directory. Problem 1) I can't see my templates. When I did the repair it rebuilt the pages correctly but all of the links point to /greymatter. Which leads me to 2) When I tired to do a comment to an entry it posted in my /greymatter directory instead of /greymatter173. I think that {{cgiwebpath}} isn't pointing to the right spot. I looked through gm-config.cgi and it looked good to me. I'm fairly certain that I could upgrade now with no problems, but before I did I thought that I should let you guys know about that first.
Thanks for all of your help!
Adam
|
|
|
Post by coldstone on Jul 16, 2007 22:33:48 GMT -5
It sounds like your paths still need tuning. The links will point based on your paths, so getting those correct is crucial. If you want, you can post the paths from the config screen here.
I was curious, but is there a reason you are manually editing the gm-config.cgi? I would recommend going through the admin page to do the edits.
When you say you can't see your templates, do you mean the templates are blank, or that you are missing the gm-templates.cgi file?
|
|
|
Post by astanley on Jul 17, 2007 5:46:34 GMT -5
I manually edited gm-config.cgi because I didn't know what would happen when I ran my test copy with it pointed to my production configuration. If it's not a big deal, I'll start over and see what happens, but I don't want to disrupt my production.
The templates are blank when I click to edit them. I copied my gm-templates.cgi over but they must not have converted.
Perhaps I'll try it all over again starting from stratch and editing gm-config.cgi from the config page.
Adam
|
|
|
Post by astanley on Jul 17, 2007 15:13:45 GMT -5
OK... I started from scratch. I copied my greymatter directory to greymatter173. Logged on. Updated the config. Everything works. Then I uploaded the new 173 code. And after I check the configuration it wipes out my templates. I looked at gm-templates.cgi and there's none on my code in there... it looks like would be the default code.
So is there something wrong in the template upgrade code or perhaps my gm-templates.cgi is corrupt?
Adam
|
|
|
Post by coldstone on Jul 17, 2007 16:48:43 GMT -5
Are you copying over the gm-templates.cgi? That file shouldn't be overwritten by the new code.
What version are you upgrading from? If its 1.6.1 or greater, you can just copy your old templates over whatever is in the greymatter173/gm-templates file.
|
|
|
Post by astanley on Jul 18, 2007 8:52:17 GMT -5
I'm not copying over gm-templates.cgi. My current version is 1.3. Would you be able to look at my current template file and see if it's corrupt or not? Any other ideas? I suppose that i could manually migrate it if I had to....
|
|
|
Post by coldstone on Jul 18, 2007 16:41:22 GMT -5
Yes, 1.3 templates are not compatible with 1.6.1 and up.
If you post a link to them (make a copy of the file in web accessable directory and rename it to be gm-templates.txt), I would like to try doing some testing in my development environment. I can then send you the converted templates.
|
|
|
Post by astanley on Jul 18, 2007 20:47:36 GMT -5
Thanks for looking into this. I just sent you a PM with the location of the file.
|
|
|
Post by coldstone on Jul 19, 2007 22:59:37 GMT -5
I sent back, can you post your gm-counter.cgi file? That may also have issues. Lastly, you'll want to clear out your gm-entrylist file and then do a Diagnosis and Repair. That should rebuild your entries.
|
|