|
Post by coldstone on May 22, 2007 17:28:24 GMT -5
Versions Affected: GreyMatter 1.7.2 and 1.7.2.3 Severity: Minor (reduces core functionality on specific screens, no workaround) Issue Description: There was an error introduced during the core refactoring . {{entrymainbodyfirstwords}} and {{entrymorebodyfirstwords}} do not work, specifically, they are always blank. However, this will only affect the search result screen and a page rebuilt after commenting.
Resolution: There is a code fix for this issue. Change lines 308 and 619 of Gm_Core from:
for( my $i = 0; $i > $firstwordscount; $i++ ){ $finalmainbodywordslist[$i] = $grabmainbodywordslist[$i]; To:
for( my $i = 0; $i < $firstwordscount; $i++ ){ push( @finalmainbodywordslist, $grabmainbodywordslist[$i] ) if( defined( $grabmainbodywordslist[$i] ) ); This issue will be fixed for 1.7.3.
|
|
|
Post by jesper on May 22, 2007 21:55:43 GMT -5
Hmm, this is odd, seems to work for me.
I use {{entrymainbodyfirstwords 20}} in my archives entries. Should i change the code anyways so it wont get skewy later on?
And OT, is there some way of limiting the words used in {{previouslink}} or {{previousentrysubject}} (Or nextXXXX), longer subjects break my design, so it would be nice to limit the size of the previous/next links.
|
|
|
Post by coldstone on May 23, 2007 18:55:34 GMT -5
Well, yes, it should work, because I forgot that in 1.7.2, I had really only refactored gm-comments.cgi to use the refactored Gm_Core template translation code. In other words, this will only happen when someone comments, or on the search results page. Good catch I know what you mean about the longer subject lines. At the moment, there isn't a way to do this that I know of. I have given up with my design and just have 'next' and 'prev' with link title attribute for the title.
|
|