Gm 1.7.3 Doesn't show all info in comment email

[coldstone]

Versions Affected: GreyMatter 1.7.3
Severity: Minor (reduces information provided)
Issue Description: When a comment is posted and an email is sent (email on comments is configured), the email is missing useful information that was previously available, such as Commenter Name, Email, Entry Title, etc.

Resolution: There is a code fix for this issue. Change line 510 of gm-comments.cgi from:
Gm_Core::sendEmail( to=>$NotifyEmail, subject=>'Notice: Comment Posted',
body=>$formattedcomment );
To:
my $emailBody = "A comment has just been posted to entry #$IN{'newcommententrynumber'} ($thisentrysubject).

Name: $IN{'newcommentauthor'} (IP: $userip)
E-Mail: $IN{'newcommentemail'}
Homepage: $IN{'newcommenthomepage'}

Comments: $formattedcomment

Posted to: $aftermath\n";

Gm_Core::sendEmail( to=>$NotifyEmail, subject=>'Notice: Comment Posted',
body=>$emailBody );

This was a result of sloppy refactoring on my part. I failed to notice during testing as well. This issue will be fixed for 1.7.4.

[tchydro]

Gm 1.3 has this same problem. I find its doing this;

This is on a w98se and on the archives 000000# file that opens up, from the comments email link, when a public places comment, it generatates and leaves the email address, it does everything a little to much though;

Writes a double mailto and email address on the actual archive entry page like this;

<p align="right"> on Monday, August 6th, <a href="mailto:<a href="mailto:[e-mail]">[e-mail]</a>">Sue</a> said
</p><p align="justify">
Of course OUTSIDE MAN, it is avaible to the Public. Why dont you read the Top POST to understand better you ding dong dingaling!!!<br />Click on my email and talk to me hopefully.
</p>

When you clik on the link to email the person, OE opens up just fine, but without anything in the To; line, to mail to, but the <a href=
Kind of like saying, I have to email to that? Does anyone know where this problem of this may be? It must be in the Library somewhere is all I can think of.... But then again, I just am not familar with pearl yet????? :-/

[tchydro]

oh yes, copyright on the 1.3 is 2000-2003

[coldstone]

Is that code coming from an email message or a web page?

The gm-comments.cgi has the text of the email messages.

However, from the snippet you posted, it looks like your template files need adjusting. I would guess your comment templates have the extra 'mailto' in them.

[tchydro]

no, it happens when a author posts to it also. I checked templates, I cannot find it.
First mailto link when you roll over it with the mouse, the bottom bar on the browser says,
mailto:<a href=

as its activation.... no email address is in the link at all.
Then the second email link says with an ok, that it will so work.
mailto:[e-mail]

So on my index, when an author posts, it leaves both email links activated but as what I have said here. First one is useless. Second one works. i cannot understand it. I cant figure why there is two of them in the first place.

[coldstone]

I think 1.3 is pre-2005, before my time