Grey Matter Forums - Gm 1.7.2 Newlines break comments sometimes

Grey Matter Forums
« Gm 1.7.2 Newlines break comments sometimes »

Welcome Guest. Please Login or Register.
Sept 2, 2010, 9:55am

Greymatter: Free Personal Blogging Software

About Greymatter (including System Requirements)

Greymatter on FreshMeat

Download current version from:

News: Greymatter 1.8.2 is released! Read the announcement.

Got a minute? We want to know what's your preferred site navigation?

Please read the security announcement regarding author passwords.

Next Greymatter release will be 1.8.3

Grey Matter Forums :: Development :: Bug Reports :: Gm 1.7.2 Newlines break comments sometimes

Author

Topic: Gm 1.7.2 Newlines break comments sometimes (Read 1,055 times)

coldstone
Global Moderator

member is offline

Joined: Aug 2006
Posts: 816
Karma: 18

Gm 1.7.2 Newlines break comments sometimes
« Thread Started on May 24, 2007, 11:09am »

Versions Affected: GreyMatter 1.7.2 and 1.7.2.3
Severity: Moderate (reduces comment functionality, workaround stops spam filtering)
Issue Description: When a comment is previewed or commenter verification is turned on, a newline in comment will trigger a security alert. This is because of the way newlines are encoded by Gm, it uses '|*|' to signify a newline.

Resolution: There is a code fix for this issue. Change line 310 of Gm_Web from:

Code:
unless( $name =~ m/^edited/i || $name =~ m/template$/i || $name =~ m/^newentry/i ){

To:

Code:
if( $name =~ m/^edited/i || $name =~ m/template$/i || $name =~ m/^newentry/i ){
## do nothing for now
} elsif( $name =~ m/^newcommentbody/i ){
if( Gm_Utils::hackWebTest( $name ) || Gm_Utils::hackWebTest( $value ) ){
&$errHandler('We don\'t take kindly to that sort of activity here. '.
'Your attempt to break the script has been logged and the administrators have '.
'been notified. <br>');
}
} else {

This issue will be fixed for 1.7.3.

Updated 5/28 per jesper's notes.

« Last Edit: May 28, 2007, 3:51pm by coldstone »

Link to Post - Back to Top IP:

Logged

jesper
New Member

member is offline

[avatar]

Joined: May 2007
Gender: Male

Posts: 35
Location: Sweden.
Karma: 5

Re: Gm 1.7.2 Newlines break comments sometimes
« Reply #1 on May 25, 2007, 5:28am »

This didnt work out for me because line 432 in my file (v1.7.2.3) read:

Code:
cat -n Gm_Web.pm|grep 432
432 ## gm_generatecalendar which enters into a loop that depends on

The closest thing i found was at line 308:

Code:
unless( $name =~ m/^edited/i || $name =~ m/template$/i ){

But after changing the code here i got:

Code:
Undefined subroutine &Gm_Security::hackWebTest called at libs/Gm_Web.pm line 311.

I got around this by changing the the line in your fix from:

Code:
if( Gm_Security::hackWebTest( $name ) || Gm_Security::hackWebTest( $value ) ){

to:

Code:
if( Gm_Utils::hackWebTest( $name ) || Gm_Utils::hackWebTest( $value ) ){

And now it seems to work, but since i have no idea what i have just done with the code, i would not recommend anyone to use my solution until the authors have given their respons to this.

Link to Post - Back to Top IP:

Logged

Carlos Phelps
Global Moderator

member is offline

Joined: Jan 2007
Gender: Male

Posts: 172
Location: California, USA
Karma: 30

Re: Gm 1.7.2 Newlines break comments sometimes
« Reply #2 on May 25, 2007, 9:13am »

jesper,

The GM you have installed on your site is the Trace Code Download if you install the standard download http://greymatter.50megs.com/release/gm_1_7_2_3_core.zip all posted bugs and corrections should apply to your site.

Link to Post - Back to Top IP:

Logged

http://rapiddialog.com

coldstone
Global Moderator

member is offline

Joined: Aug 2006
Posts: 816
Karma: 18

Re: Gm 1.7.2 Newlines break comments sometimes
« Reply #3 on May 28, 2007, 3:47pm »

Thanks jesper, another good catch. The Gm_Security module is new to 1.7.3 and its the same function, just in a more appropriate place. I will modify the original post.

My apologies to people who tried to use the original post, it is based on 1.7.3 code, instead of 1.7.2.

Link to Post - Back to Top IP:

Logged

Click Here To Make This Board Ad-Free

This Board Hosted For FREE By ProBoards
Get Your Own Free Message Boards & Free Forums!
Terms of Service | Privacy Policy | Report Abuse | Mobile